You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds IMateStatService/MateStatService: a pet's close, ranged and magic defence, dodge, minimum and maximum damage and hit rate at its own level, before the flat modifiers of its monster entry.
A pet follows the monster curves of its race with its weapon and armour at the pet's level. Each curve's level share grows by one of the entry's three growth factors (MateGrowth):
melee: close defence and melee damage
ranged: ranged defence, dodge, hit rate and ranged damage
magic: magic defence and magic damage
The growth is in tenths per level above the first for dodge, damage and hit rate, and in twentieths for the defences, inside the same floor as the level share. With all three at 0 the stats are those of a monster of that level.
The race curves move to an internal MonsterCurves class shared by both services. MonsterStatService's output is unchanged, and its approval table still passes.
Checked against the published per-level stats of 11 pets (races 0 and 2, all three attack classes, levels 1 to 99): every value matches. MateStatDocumentation asserts a sample and adds an approval table.
MateStatService gives a pet's defences, dodge, damage and hit rate at its
own level: the monster curves of its race with weapon and armour at the
pet's level, each level share grown by the entry's melee, ranged or magic
growth factor.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014gSmkUgtue8mHJ8prh9NdK
No actionable comments were generated in the recent review.
Walkthrough
The change extracts monster stat curves into MonsterCurves, adds a growth-aware pet stat API, and adds tests and approved tables for selected race 0 levels and growth profiles.
Changes
Monster and pet stat calculations
Layer / File(s)
Summary
Extract and reuse monster curves src/NosCore.Algorithm/MonsterStatService/MonsterCurves.cs, src/NosCore.Algorithm/MonsterStatService/MonsterStatService.cs
MonsterCurves contains race-specific curves and calculations for defence, dodge, damage, and hit rate. MonsterStatService delegates these calculations to MonsterCurves; its critical-stat getters remain unchanged.
Add growth-aware pet stat calculations src/NosCore.Algorithm/MateStatService/*, test/NosCore.Algorithm.Tests/DocumentationTest.cs, documentation/DocumentationTest.MateStatDocumentation.approved.md
MateGrowth defines melee, ranged, and magic growth factors. MateStatService uses these factors for pet stat calculations. The test checks representative outputs and generates a race 0 table for five growth profiles and eight levels.
NosCoreIO/NosCore.Algorithm#169: Adds the monster curve calculations that this PR extracts into MonsterCurves and reuses for pet stats.
Suggested reviewers: claude
Merge Risk: Minimal · up to da1df
This change adds pet stat calculations and moves the monster curves into a shared class. Existing monster stat results should be unchanged, and no concrete defects were found. It looks ready to merge, subject to the normal test run.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title 'Add pet attack, defence and dodge curves' matches the main change. The PR adds IMateStatService and MateStatService, which calculate a pet's defences, dodge, minimum and maximum damage, and…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title 'Add pet attack, defence and dodge curves' matches the main change. The PR adds IMateStatService and MateStatService, which calculate a pet's defences, dodge, minimum and maximum damage, and hit rate. MonsterCurves holds the shared curve logic, and MonsterStatService delegates to it. The title names the primary change and stays specific.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
IMateStatService/MateStatService: a pet's close, ranged and magic defence, dodge, minimum and maximum damage and hit rate at its own level, before the flat modifiers of its monster entry.A pet follows the monster curves of its race with its weapon and armour at the pet's level. Each curve's level share grows by one of the entry's three growth factors (
MateGrowth):The growth is in tenths per level above the first for dodge, damage and hit rate, and in twentieths for the defences, inside the same floor as the level share. With all three at 0 the stats are those of a monster of that level.
The race curves move to an internal
MonsterCurvesclass shared by both services.MonsterStatService's output is unchanged, and its approval table still passes.Checked against the published per-level stats of 11 pets (races 0 and 2, all three attack classes, levels 1 to 99): every value matches.
MateStatDocumentationasserts a sample and adds an approval table.New service only, so a minor version: 6.3.0.
Generated by Claude Code
Summary by CodeRabbit